Improved huggingface batch logic#1336
Conversation
adriangonz
left a comment
There was a problem hiding this comment.
Changes look good! Thanks for taking the time to contribute this patch @ajsalow.
Before merging, could you add a test covering the new behaviour? Besides that, there also seem to be some conflicts with latest master.
|
Thanks for taking a look @adriangonz. I've added some test coverage, let me know if anything else is needed. |
There was a problem hiding this comment.
Looks good! Thanks for adding that test @ajsalow 👍
Once tests are green, we should be able to merge this one.
|
Hey @ajsalow , Just had a look at the test failures. I think from those, the |
|
@adriangonz apologies, I incorrectly assumed linting was using pylint. |
Addresses issues described in #1249 where batch size greater than 0 causes some hugging face models to fail loading.