Skip to content

Fix settings reference in runtime docs#1109

Merged
adriangonz merged 13 commits into
SeldonIO:masterfrom
adriangonz:fix-runtime-docs-reference
Apr 20, 2023
Merged

Fix settings reference in runtime docs#1109
adriangonz merged 13 commits into
SeldonIO:masterfrom
adriangonz:fix-runtime-docs-reference

Conversation

@adriangonz

Copy link
Copy Markdown
Contributor

No description provided.

@adriangonz adriangonz requested a review from ascillitoe April 19, 2023 16:35
Comment thread docs/requirements.txt Outdated

@ascillitoe ascillitoe left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Edit: just noticed the new RTD install logic does introduce a few errors with protobuf in the RTD build logs (during installation), which in turn leads to errors with optimum.onnxruntime. However, I can't imagine this affecting the docs buidl itself...

@adriangonz

Copy link
Copy Markdown
Contributor Author

Docs seem to now be working for both the Huggingface and Alibi Detect runtimes!

@adriangonz adriangonz merged commit 1c9ca37 into SeldonIO:master Apr 20, 2023
@adriangonz adriangonz deleted the fix-runtime-docs-reference branch April 20, 2023 15:54
adriangonz pushed a commit that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants