Feat better mobile context menu#946
Merged
Merged
Conversation
Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
…text-menu Merge upsream
…tion Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
…text-menu merge upsream again
Signed-off-by: Shea <nu@she-a.eu>
nushea
force-pushed
the
feat-better-mobile-context-menu
branch
from
0118e08 to
b3a9ed6
Compare
Signed-off-by: Shea <nu@she-a.eu>
nushea
force-pushed
the
feat-better-mobile-context-menu
branch
from
b3a9ed6 to
3c00726
Compare
Signed-off-by: Shea <nu@she-a.eu>
nushea
force-pushed
the
feat-better-mobile-context-menu
branch
from
84b307e to
2508a73
Compare
Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
nushea
force-pushed
the
feat-better-mobile-context-menu
branch
from
ab8be86 to
1fd626c
Compare
7w1
approved these changes
Jun 23, 2026
Signed-off-by: Shea <nu@she-a.eu>
Signed-off-by: Shea <nu@she-a.eu>
nushea
force-pushed
the
feat-better-mobile-context-menu
branch
from
d5ab781 to
9c01b79
Compare
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-946-sable.raspy-dream-bb1d.workers.dev | 9c01b79 | pr-946 |
Tue, 23 Jun 2026 22:04:01 GMT |
This was referenced Jun 28, 2026
Just-Insane
added a commit
to CloudHub-Social/Charm-1.0
that referenced
this pull request
Jul 2, 2026
MessageTextBody's jumboEmoji variants lost their paddingTop/paddingBottom
(0.08em) and --sable-{system,custom}-emoji-top-offset CSS vars in
ade0bcb (SableClient#946, "Feat better mobile context menu"), an external feature
PR that branched from an older base and silently reverted an unrelated
spacing-cascade fix. The immediate follow-up (435d65c) restored the
ContentSpacingVar/withVarFallback mechanism on MessageBase but missed
that MessageTextBody's own jumbo-emoji padding was also dropped, since
the two live in the same recipe file but are logically separate concerns.
This is a real production bug, not a test-fixture artifact: two
jumbo-emoji-only messages from the same sender rendered back-to-back
(verified live via the emoji-qa smoke fixture, which wraps
MessageTextBody in MessageBase exactly as Message.tsx does) show zero
gap between their line boxes beyond the fixed 4px Box gap, because
MessageBase's row padding only applies at the row's outer edges, not
between sibling MessageTextBody lines within one row.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a context menu for mobile, refactors the option menus, and unifies events and messages to a limited degree, it also fixes some focus issues
The pr does NOT fix quickmenu being underlayed in the thread root, or the entirety or focus issues. These issues could be fixed in the future with the help of this by creating an atom and showing the quickemenu as a unique item in the RoomView but that would still require a lot of work, it also does NOT unify the events and messages entirely or reduce the amount of data that is requested before usage, though it enables it for future development, nor does it the rightclicking outside of the MessageInternal/children but still within the message not bringing the menu
(view of the menu on a random real message)
(maximum size of a mobile menu)
(this pr does NOT remove the mobile quickmenu so you can still access the message the old way)
If you wish to select text from a message you have to first bring the menu and then select it from it
Fixes #
Type of change
Checklist:
AI disclosure:
This is being written w the assistance of whatever music is in my ears while writing it :p