Fix timeline items being rerendered constantly#1055
Merged
Conversation
Contributor
Deploying with
|
| Status | Preview URL | Commit | Alias | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! | https://pr-1055-sable.raspy-dream-bb1d.workers.dev | 47186d8 | pr-1055 |
Sat, 11 Jul 2026 05:37:46 GMT |
charm-cloudhub-social Bot
pushed a commit
to CloudHub-Social/Charm-1.0
that referenced
this pull request
Jul 12, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Fixes * Fix some image embeds not creating embeds. ([SableClient#1062](<SableClient#1062>) by @7w1) * Allow rooms with empty local parts to be viewed. ([SableClient#1062](<SableClient#1062>) by @7w1) * Fix the account button showing you 0 sessions active and the verify this device showing when you have zero devices to verify ([SableClient#1064](<SableClient#1064>) by @nushea) * Various performance optimizations ([SableClient#1062](<SableClient#1062>) by @7w1) * Fixed the entire timeline being rerendered every time you scroll :P ([SableClient#1055](<SableClient#1055>) by @7w1) ## Notes * Added a new workflow that automatically previews dev on [dev.sable.moe](https://dev.sable.moe) ([SableClient#1059](<SableClient#1059>) by @7w1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So as Niki pointed out while working on galleries (i think?) timeline items rerender a lot. I never noticed, but uh, turns out this might matter for weaker devices, and comparing them side by side I do actually notice now.
We we're memoizing the components within timeline items, but the timeline items themselves we're being called every single scroll tick, which reduced the efficiency of that inner memoization quite a bit.
Type of change
Checklist:
AI disclosure: