Establish Codex typed API foundation and operation contracts#218
Merged
Conversation
VolkerChristian
marked this pull request as ready for review
July 23, 2026 18:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase A1.0
One PR, one feature branch, and exactly two review/validation commits above
masterat6c0396526c6a06cd2f3d9a05e7d24163c9a980e6:7377f3581bab2af0bf3e18edbfbb49a91157d03b Establish offline Codex operation evidencecfc129ec879c70fc09c165035f6d1390f61289b8 Introduce Codex typed foundation and migrate existing surfaceA1.0a — offline evidence and fixtures
Commit 1 CI: run 30028759871 / #314 completed successfully.
A1.0b — typed foundation and migration
typed::Clientfacade andAppServerClient::typed(); the old four accessors remain deprecated source-compatible forwarders.AppServerClientat its existing PIMPL-only layout and reuses the existing raw connection, ID allocator, pending registry, observers, and facade objects.CodexErrorInfodiscriminators.ThreadItem/ futureResponseItemdirection while preservingusing Item = ThreadItem.client.typed()and preserves typed-but-A2-unmodeled events through the existing bounded extension path.Final local validation at PR head
ctest -N: 252 registered tests.git diff --checkpassed.Final CI: run 30032936320 / #315 completed successfully for
cfc129ec879c70fc09c165035f6d1390f61289b8; jobgcc-debug(89293671727) passed checkout, dependency installation, configure, build, tests, and cleanup.This PR intentionally remains open and draft. It does not implement A1.1–A1.4, A2, A3, or Qt work, and Codex will not merge it.