Skip to content

aead: remove heapless support #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
newpavlov merged 4 commits into from
Sep 5, 2025
Merged

aead: remove heapless support #1999

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b6bc216
aead: remove `heapless` support
newpavlov Sep 5, 2025
74d0332
tweak changelog entry
newpavlov Sep 5, 2025
89c475e
fix CI
newpavlov Sep 5, 2025
3e73354
Disable dev macro tests
newpavlov Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 7 additions & 48 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions aead/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased
### Fixed
- minor documentation error in `AeadCore::TagSize` ([#1351])
- fixup `hybrid-array` migration ([#1531])
- Minor documentation error in `AeadCore::TagSize` ([#1351])
- Fixup `hybrid-array` migration ([#1531])

### Changed
- Edition changed to 2024 and MSRV bumped to 1.85 ([#1759])
- Migrate to `doc_auto_cfg` ([#1370])
- Exclude pre-1.60 crates from workspace ([#1380])
- bump `crypto-common` to v0.2.0-pre; MSRV 1.65 ([#1384])
- Bump `heapless` dependency to v0.8 ([#1398])
- Bump `crypto-common` to v0.2.0-pre; MSRV 1.65 ([#1384])
- Bump `hybrid-array` to v0.2.0-pre.6 ([#1432])
- Bump `crypto-common` to v0.2.0-pre.1 ([#1433])
- Bump `crypto-common` to v0.2.0-pre.2 ([#1436])
Expand All @@ -24,14 +23,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Bump `crypto-common` to v0.2.0-pre.5 ([#1496])

### Added
- enable `missing_debug_implementations` lint and add `Debug` impls ([#1411])
- Enable `missing_debug_implementations` lint and add `Debug` impls ([#1411])

### Removed
- `heapless` support ([#1999])
Comment thread
newpavlov marked this conversation as resolved.
Outdated


[#1351]: https://github.com/RustCrypto/traits/pull/1351
[#1370]: https://github.com/RustCrypto/traits/pull/1370
[#1380]: https://github.com/RustCrypto/traits/pull/1380
[#1384]: https://github.com/RustCrypto/traits/pull/1384
[#1398]: https://github.com/RustCrypto/traits/pull/1398
[#1411]: https://github.com/RustCrypto/traits/pull/1411
[#1432]: https://github.com/RustCrypto/traits/pull/1432
[#1433]: https://github.com/RustCrypto/traits/pull/1433
Expand All @@ -41,6 +42,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
[#1496]: https://github.com/RustCrypto/traits/pull/1496
[#1531]: https://github.com/RustCrypto/traits/pull/1531
[#1759]: https://github.com/RustCrypto/traits/pull/1759
[#1999]: https://github.com/RustCrypto/traits/pull/1999

## 0.5.2 (2023-04-02)
### Added
Expand Down
1 change: 0 additions & 1 deletion aead/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ inout = "0.2.0-rc.6"
arrayvec = { version = "0.7", optional = true, default-features = false }
blobby = { version = "0.4.0-pre.0", optional = true }
bytes = { version = "1", optional = true, default-features = false }
heapless = { version = "0.8", optional = true, default-features = false }

[features]
default = ["rand_core"]
Expand Down
13 changes: 0 additions & 13 deletions aead/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ pub use arrayvec;
pub use bytes;
#[cfg(feature = "rand_core")]
pub use crypto_common::rand_core;
#[cfg(feature = "heapless")]
pub use heapless;
pub use inout;

use core::fmt;
Expand Down Expand Up @@ -512,17 +510,6 @@ impl<const N: usize> Buffer for arrayvec::ArrayVec<u8, N> {
}
}

#[cfg(feature = "heapless")]
impl<const N: usize> Buffer for heapless::Vec<u8, N> {
fn extend_from_slice(&mut self, other: &[u8]) -> Result<()> {
heapless::Vec::extend_from_slice(self, other).map_err(|_| Error)
}

fn truncate(&mut self, len: usize) {
heapless::Vec::truncate(self, len);
}
}

#[cfg(test)]
mod tests {
use super::*;
Expand Down
Loading