jose-jwk: import legacy impl from the elliptic-curve crate#85
Merged
Conversation
The `elliptic-curve` crate previously shipped with its own JWK impl: http://docs.rs/elliptic-curve/0.13.8/elliptic_curve/struct.JwkEcKey.html To keep the `elliptic-curve` crate simpler and avoid duplication within the project, this extracts the implementation into the `jose-jwk` crate. Ideally we could consolidate into a single implementation, however the legacy implementation offers some features the existing implementation does not like encoding support. Extracting the implementation out provides an easy migration path for existing users until we can consolidate into a single implementation which covers all bases.
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Aug 18, 2025
Migrated to the `jose-jwk` crate in RustCrypto/JOSE#85
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Aug 18, 2025
Migrated to the `jose-jwk` crate in RustCrypto/JOSE#85
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Aug 18, 2025
Migrated to the `jose-jwk` crate in RustCrypto/JOSE#85
tarcieri
added a commit
to RustCrypto/traits
that referenced
this pull request
Aug 18, 2025
Migrated to the `jose-jwk` crate in RustCrypto/JOSE#85
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
elliptic-curvecrate previously shipped with its own JWK impl:http://docs.rs/elliptic-curve/0.13.8/elliptic_curve/struct.JwkEcKey.html
To keep the
elliptic-curvecrate simpler and avoid duplication within the project, this extracts the implementation into thejose-jwkcrate.Ideally we could consolidate into a single implementation, however the legacy implementation offers some features the existing implementation does not like encoding support. Extracting the implementation out provides an easy migration path for existing users until we can consolidate into a single implementation which covers all bases.