Fix streaming downloads using request - #160
Merged
hhellyer merged 1 commit intoFeb 24, 2016
Merged
Conversation
Member
|
Merging, since this broke the install from github via npm install we can close the issue once we've done: |
hhellyer
added a commit
that referenced
this pull request
Feb 24, 2016
Fix streaming downloads using request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently realised that downloads were failing on the latest version. This PR attempts to fix the failures and also ensure the change that caused the issue (enabling support for download behind a proxy) continue to work.
@DanCunnington kindly tested this works behind a proxy.
Fixes #159