Update TwoFactorAuth.php#116
Closed
motsmanish wants to merge 1 commit into
Closed
Conversation
Deprecated function: rawurlencode(): Passing null to parameter RobThree#1
Collaborator
|
Thanks for your attention but aren't those two variables type hinted by the function declaration so can only be strings? |
Collaborator
|
I agree with Will, this change makes no sense. Recommend closing this. |
Owner
|
Agree with all above. |
Author
|
In one of our projects, we use usernames instead of emails. This led to an issue where the library received a null value for the label, causing the error: 'Deprecated function: rawurlencode(): Passing null to parameter'. But no worries, I’ll ensure to include more specific details next time I report an issue. |
Collaborator
|
@motsmanish is it possible you had an older version of the library which didn't have type hinting (see #97)? |
Author
|
You are right, as per composer "robthree/twofactorauth": "^1.8.1". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated function: rawurlencode(): Passing null to parameter #1