Skip to content

CONTRIBUTING.md: add section about extractive contributions - #22706

Merged
AnnsAnns merged 1 commit into
RIOT-OS:masterfrom
maribu:CONTRIBUTING.md/extractive-contributions
Sep 18, 2026
Merged

CONTRIBUTING.md: add section about extractive contributions#22706
AnnsAnns merged 1 commit into
RIOT-OS:masterfrom
maribu:CONTRIBUTING.md/extractive-contributions

Conversation

@maribu

@maribu maribu commented Sep 15, 2026

Copy link
Copy Markdown
Member

Contribution description

This adds a section about what extractive contributions are, why we as a project need to protect our community from extractive contributions, and guide authors of extractive contributions how they can become a valuable community member.

Testing procedure

Assume that you just got your issue / PR closed with little more than a link to this section. Read this section and check whether:

  • you understand why your PR / issue was closed
  • why it is justified that the RIOT community doesn't invest a lot of contributions on fully vibed PRs / issues
  • what good first steps would be if you actually are interested in investing time to become a valuable member of the RIOT community

Issues/PRs references

Triggered by #22702

Declaration of AI-Tools / LLMs usage:

No LLM ("AI") tool was contributing directly. But it more than fair to say that LLMs motivated me to create this PR.

@github-actions github-actions Bot added the Area: doc Area: Documentation label Sep 15, 2026
@maribu maribu mentioned this pull request Sep 15, 2026
Closed
@mguetschow

mguetschow commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Thanks for that! But I had the feeling, and just re-checked, that there is already https://github.com/RIOT-OS/RIOT/blob/master/doc/guides/general/ai_policy.md?plain=1#L78

I agree that it makes sense to add something to CONTRIBUTING.md about this, but maybe a link would do?

Haven't checked the text to see if it could be used to improve the AI policy.

@crasbe crasbe added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs AI: Not Used AI was stated to not be used in this PR/Issue labels Sep 15, 2026
crasbe
crasbe reviewed Sep 15, 2026
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
leandrolanzieri
leandrolanzieri reviewed Sep 15, 2026
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
AnnsAnns
AnnsAnns approved these changes Sep 15, 2026
View reviewed changes

@AnnsAnns AnnsAnns left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the other reviewers already addressed the feedback I had so looks good from my side now :)

@riot-ci

riot-ci commented Sep 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Murdock results

✔️ PASSED

9e853bc CONTRIBUTING.md: add section about extractive contributions

Success Failures Total Runtime
1 0 1 03m:20s

Artifacts

maribu
maribu commented Sep 15, 2026
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
maribu
maribu commented Sep 15, 2026
View reviewed changes
Comment thread CONTRIBUTING.md Outdated
mguetschow
mguetschow approved these changes Sep 16, 2026
View reviewed changes

@mguetschow mguetschow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adapting!

@AnnsAnns

AnnsAnns commented Sep 16, 2026

Copy link
Copy Markdown
Member

3 Acks feels like more than enough to squash and merge 😄

@maribu

maribu commented Sep 16, 2026

Copy link
Copy Markdown
Member Author

Thanks for adapting!

Thx for pointing out the duplication :-)

3 Acks feels like more than enough to squash and merge 😄

afk right now. Will do so later today

@AnnsAnns

AnnsAnns commented Sep 16, 2026

Copy link
Copy Markdown
Member

writes is away from keyboard right now
written on keyboard

🤨 Maribu that's not very away from keyboard from you (No pressure, you can self merge whenever you get the time)

@maribu
CONTRIBUTING.md: add section about extractive contributions
9e853bc 
- add a section about extractive contributions to CONTRIBUTING.md
- refer to the definition of them in the AI policy
- explain why we as a project need to protect our community from
  extractive contributions
- and a pointer to authors of extractive contributions how they can
  become a valuable community member

Co-authored-by: crasbe <crasbe@gmail.com>
Co-authored-by: Leandro Lanzieri <leandro.lanzieri@haw-hamburg.de>

Apply suggestion from @maribu

Apply suggestion from @maribu
@maribu
maribu force-pushed the CONTRIBUTING.md/extractive-contributions branch from 7ec8b6b to 9e853bc Compare September 18, 2026 08:27
@AnnsAnns
AnnsAnns enabled auto-merge September 18, 2026 10:07
@AnnsAnns
AnnsAnns added this pull request to the merge queue Sep 18, 2026
@AnnsAnns

AnnsAnns commented Sep 18, 2026

Copy link
Copy Markdown
Member

Its also funny that we already had an instance where I wanted to link to this in a PR before realizing this wasn't merged yet, looks like its fairly useful 😄

Merged via the queue into RIOT-OS:master with commit e9c7ece Sep 18, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crasbe crasbe crasbe left review comments
@leandrolanzieri leandrolanzieri leandrolanzieri left review comments
@mcr mcr mcr approved these changes
@Teufelchen1 Teufelchen1 Teufelchen1 approved these changes
@AnnsAnns AnnsAnns AnnsAnns approved these changes
@mguetschow mguetschow mguetschow approved these changes

Assignees

No one assigned

Labels

AI: Not Used AI was stated to not be used in this PR/Issue Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@maribu @mguetschow @riot-ci @AnnsAnns @mcr @crasbe @leandrolanzieri @Teufelchen1