Skip to content

Bug fixes and minor enhancements#53

Merged
trappitsch merged 15 commits into
mainfrom
bug_fixes_and_minor_enhancements
Sep 1, 2022
Merged

Bug fixes and minor enhancements#53
trappitsch merged 15 commits into
mainfrom
bug_fixes_and_minor_enhancements

Conversation

@trappitsch

@trappitsch trappitsch commented Aug 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • In MPL toolbar: Untoggle pan button after using it
  • Add method to sort backgrounds by Z, Mass, Start mass
  • Incorporate sorting method into background drawing GUI
  • Create routine that can check if integrals and backgrounds overlap and either correct it or warn the user
  • Create routine to check for peak overlaps in def_integrals

@trappitsch
In MPL toolbar: Untoggle pan button after using it
946d3e9 
This is the same that we already do with the Zoom tool.
@trappitsch
Add method to sort backgrounds by Z, Mass, Start mass
7c7784d
@trappitsch
Extend test for sort_backgrounds()
c6f81dc
@trappitsch
Refractor the sort integral out into the processor utils
4ec5aab 
This way, we can use it as well in the GUI that draws backgrounds
@trappitsch
Sort backgrounds when "drawn backgrounds" are applied
7007826
@trappitsch
Refractor integral sorting into it's own processor_utils routine
a1e9bd4 
Also fix lint
@trappitsch
Sorting integrals after drawing them now uses the processor_utils method
03b60f5
@trappitsch
First implementation of working background autoadjust
0888b3f
@trappitsch
Draw BG GUI uses now the processor_utils overlap checker
bf788be
@trappitsch
Move bg in integral checker into overlap chk, draw integral gui adopted
3dd47c1 
- After setting integrals, the overlap checker now ensures that backgrounds without integrals are deleted
- Drawing Integral GUI now runs the autoscaler and throws an error if backgrounds and peaks overlap, even though backgrounds cannot be seen
@trappitsch
Fix lint
e0ba068
@trappitsch
Add methods to check for peak overlap
b84acec
@trappitsch
Extend tests for peak overlap checking
305e096
@trappitsch
Fix Excel writer to apply format to 999 cells
b19fceb
@trappitsch
Fix multiprocessor to apply backgrounds before integrals, NEEDS TEST
5f3279c
@trappitsch trappitsch merged commit 300c995 into main Sep 1, 2022
@trappitsch trappitsch deleted the bug_fixes_and_minor_enhancements branch September 1, 2022 08:04
This was referenced Sep 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@trappitsch