BF: Create tof data from arrival bins when bin ranges in header wrong#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous CRD files created by
LIONEvalhave bad header data, i.e., the bin ranges are incorrect. In that case, the program recreated the whole tof data by just assuming that the first ion that hit is at zero ToF. Now we are correcting this by offsetting with the first ion arrival bin's time of flight.This fixes a bug that made the ToF spectra of old files be misaligned, i.e., the absolute tof depended on the arrival time of the first ion, which is not generally the same from measurement to measurement.