Skip to content

Remove leading comments from terminal submission (#1244)#1245

Merged
renkun-ken merged 6 commits into
REditorSupport:masterfrom
gowerc:master
Feb 1, 2023
Merged

Remove leading comments from terminal submission (#1244)#1245
renkun-ken merged 6 commits into
REditorSupport:masterfrom
gowerc:master

Conversation

@gowerc

@gowerc gowerc commented Oct 30, 2022

Copy link
Copy Markdown
Contributor

What problem did you solve?

Code removes leading comments from code submitted to terminal (issue #1244)

(If you have)Screenshot

remove_comments_screencast.webm

@gowerc

gowerc commented Oct 31, 2022

Copy link
Copy Markdown
Contributor Author

I’m now wondering if this instead should be moved to within expandselction? This current implementation would also strip leading comments off of explicitly highlighted chunks of code, though maybe that’s not an issue, I’m not too sure?

Comment thread src/selection.ts Outdated

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!

@renkun-ken
renkun-ken merged commit 07fa8fb into REditorSupport:master Feb 1, 2023
@gowerc

gowerc commented Feb 1, 2023

Copy link
Copy Markdown
Contributor Author

Just wanted to apologies for not getting around to finishing this off myself, we just had a baby daughter which is consuming all my spare time at the moment 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants