You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR avoids a file lock issue (observed on windows, probably not an issue on linux): Sourcing .R file using R -f xxx.R locks the file and as a consequence it's impossible to reinstall this extension while it is running. This is particularly annoying when working on the extension itself, since it contains R code and is therefore activated automatically.
This problem is solved by sourcing .R files using R -e source('xxx.r'), which does not appear to lock the file.
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it is a good idea to use source() instead of direct supplying a file. Changing the content of an R file while it is running by Rscript might cause the R session to fail sometimes.
Not sure if it is a good idea to use source() instead of direct supplying a file. Changing the content of an R file while it is running by Rscript might cause the R session to fail sometimes.
This problem would be solved by using source(), since source first parses the entire file and then starts executing. Therefore, background processes like the languageserver and helpserver do not depend on the original file at all, once they start running. IMO this is the ideal behavior. In contrast, on windows Rscript locks the file, making it impossible to quickly reinstall the extension.
On Linux/macos, I'm not sure how exactly this is handled by Rscript. Apparently it is possible to write a script that deletes itself (and does something afterwards) and run it with Rscript, but I'm not sure what the limits to this are (i.e. whether Rscript always reads the entire file first, or I just got lucky and my test script was short enough to be read at once).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR avoids a file lock issue (observed on windows, probably not an issue on linux): Sourcing .R file using
R -f xxx.Rlocks the file and as a consequence it's impossible to reinstall this extension while it is running. This is particularly annoying when working on the extension itself, since it contains R code and is therefore activated automatically.This problem is solved by sourcing .R files using
R -e source('xxx.r'), which does not appear to lock the file.