Click code in help views#1138
Merged
Merged
Conversation
ManuelHentschel
marked this pull request as ready for review
June 29, 2022 10:45
ManuelHentschel
changed the title
renkun-ken
reviewed
Jul 1, 2022
| "enum": [ | ||
| "Disabled", | ||
| "Copy", | ||
| "Run" |
Member
There was a problem hiding this comment.
It is nice to have the capability to either copying or running the example code. I wonder if it is possible to have both at the same time. For example, click to copy, and cmd+click to run, or something like this?
Member
Author
There was a problem hiding this comment.
Good idea. I wasn't sure how to handle the possible modifier keys best, especially w.r.t. mac (Should we just make them all configurable, or are there sensible "groupings"?).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #459 #1137
Code sections in the help viewer are highlighted on hover, and can be clicked to be copied to the clipboard, or run in the terminal.
The behavior can be modified with the setting
"r.helpPanel.clickCodeExamples". Changes to this setting might require reloading the window to take effect.