Skip to content

Add file creation to file/newFile#1119

Merged
renkun-ken merged 1 commit into
REditorSupport:masterfrom
ElianHugh:new-file
Jun 5, 2022
Merged

Add file creation to file/newFile#1119
renkun-ken merged 1 commit into
REditorSupport:masterfrom
ElianHugh:new-file

Conversation

@ElianHugh

@ElianHugh ElianHugh commented Jun 2, 2022

Copy link
Copy Markdown
Collaborator

What problem did you solve?

VSCode-R currently doesn't have any menu items contributed to VSCode's native file dialog Create: new file. This adds RMD files and R files to the dialog box.

(If you have)Screenshot

image

(If you do not have screenshot) How can I check this pull request?

Access the file dialog via Create: new file dialog

@renkun-ken renkun-ken left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Works nicely! Thanks!

@renkun-ken

Copy link
Copy Markdown
Member

I'm wondering why Python and Jupyter notebook still appear even when the Python extension is not activated?

image

@ElianHugh

Copy link
Copy Markdown
Collaborator Author

I'm wondering why Python and Jupyter notebook still appear even when the Python extension is not activated?

image

Very weird. I can't replicate this with Python, but Jupyter is still showing up for me. I don't think this is our fault? o.0

@eitsupi

eitsupi commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

I think ipynb is a feature of vscode (was it in the news a few months ago?).

@renkun-ken
renkun-ken merged commit cb51776 into REditorSupport:master Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants