Skip to content

Fix clippy for Rust 1.83#1332

Merged
IvanIsCoding merged 5 commits into
Qiskit:mainfrom
airwoodix:fix-1331
Nov 30, 2024
Merged

Fix clippy for Rust 1.83#1332
IvanIsCoding merged 5 commits into
Qiskit:mainfrom
airwoodix:fix-1331

Conversation

@airwoodix

Copy link
Copy Markdown
Contributor

Resolves #1331

@coveralls

coveralls commented Nov 29, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 12098140853

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.869%

Totals Coverage Status
Change from base Build 11991065969: 0.0%
Covered Lines: 18287
Relevant Lines: 19075

💛 - Coveralls

@airwoodix
airwoodix marked this pull request as ready for review November 29, 2024 22:04
@IvanIsCoding

Copy link
Copy Markdown
Collaborator

Thanks for handling the Clippy lints. I just removed the public release note because for internal changes like addressing cargo clippy/cargo fmt/black/ruff we don't bother documenting. Especially because Clippy possibly triggers every Rust release.

Comment thread src/iterators.rs
Comment thread src/lib.rs
@IvanIsCoding
IvanIsCoding added this pull request to the merge queue Nov 30, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 30, 2024
@IvanIsCoding
IvanIsCoding added this pull request to the merge queue Nov 30, 2024
Merged via the queue into Qiskit:main with commit b66662f Nov 30, 2024
@airwoodix
airwoodix deleted the fix-1331 branch November 30, 2024 18:57
SILIZ4 pushed a commit to SILIZ4/rustworkx that referenced this pull request Jul 4, 2025
* clippy: fix empty_line_after_doc_comment

* clippy: fix empty_line_after_outer_attr

* clippy: autofix needless_return and needless_lifetimes

* reno: add fragment for Qiskit#1332

* Revert "reno: add fragment for Qiskit#1332"

This reverts commit 9d1b0c9.

---------

Co-authored-by: Ivan Carvalho <ivancarv@student.ubc.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clippy fails on Rust 1.83

3 participants