auditwheel choose higher priority tag when possible - #456
Merged
Conversation
messense
force-pushed
the
auditwheel-higher-priority
branch
2 times, most recently
from
March 2, 2021 01:02
93e8822 to
d29523c
Compare
messense
commented
Mar 2, 2021
messense
force-pushed
the
auditwheel-higher-priority
branch
from
March 2, 2021 13:14
d29523c to
d11a4c9
Compare
konstin
reviewed
Mar 3, 2021
konstin
reviewed
Mar 3, 2021
konstin
reviewed
Mar 3, 2021
| .is_ok() | ||
| { | ||
| println!( | ||
| "📦 Wheel is eligible for a higher priority tag. You requested {} but I have found this wheel is eligible for {}", |
Member
|
I think the ideal solution would be having three categories:
There might be a case for a fourth option, This PR is already a huge improvement as-is, so I'm happy with merging this now and figuring out the specifics of the cli arguments later |
Member
Author
Sure, let's do that later in #448 |
Member
Author
Do you mean |
Member
|
Oops, yes that should have been |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example: