Skip to content

UniFFI: supports bindings generated from multiple crates - #2208

Merged
messense merged 6 commits into
PyO3:mainfrom
MatMaul:multiple-crates
Sep 4, 2024
Merged

UniFFI: supports bindings generated from multiple crates#2208
messense merged 6 commits into
PyO3:mainfrom
MatMaul:multiple-crates

Conversation

@MatMaul

@MatMaul MatMaul commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

This changes allow to build a functional wheel of Matrix Rust SDK FFI bindings.

@netlify

netlify Bot commented Sep 2, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for maturin-guide ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d9eaa0e
🔍 Latest deploy log https://app.netlify.com/sites/maturin-guide/deploys/66d6f4a9f17448000890ff4b
😎 Deploy Preview https://deploy-preview-2208--maturin-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatMaul MatMaul mentioned this pull request Sep 2, 2024
Closed
1 task
@MatMaul MatMaul changed the title Add support for bindings generated from multiple crates UniFFI: supports bindings generated from multiple crates Sep 2, 2024
@MatMaul MatMaul mentioned this pull request Sep 2, 2024
Closed
@messense

messense commented Sep 3, 2024

Copy link
Copy Markdown
Member

Thanks for the PR, could you please add a test crate in test-crates/ and write a test case? (See https://github.com/PyO3/maturin/blob/main/tests/run.rs)

messense
messense reviewed Sep 3, 2024
View reviewed changes
Comment thread src/module_writer.rs Outdated
Comment thread src/module_writer.rs Outdated
@messense messense added the bindings/uniffi uniffi bindings label Sep 3, 2024
MatMaul and others added 5 commits September 3, 2024 09:50
@MatMaul @messense
Update src/module_writer.rs
05d5b02 
Co-authored-by: messense <messense@icloud.com>
@MatMaul @messense
Update src/module_writer.rs
dee57ef 
Co-authored-by: messense <messense@icloud.com>
@MatMaul
fmt
46119ac
@MatMaul
Add test
7e39bf6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d9eaa0e 
for more information, see https://pre-commit.ci
@MatMaul

MatMaul commented Sep 3, 2024

Copy link
Copy Markdown
Contributor Author

Good idea, minimal test case added.

messense
messense approved these changes Sep 4, 2024
View reviewed changes

@messense messense left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@messense
messense merged commit 06ee2f3 into PyO3:main Sep 4, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 24, 2024
Merged
This was referenced Nov 9, 2024
Closed
Closed
Merged
@davidhewitt davidhewitt mentioned this pull request Nov 9, 2025
Merged
messense added a commit that referenced this pull request Feb 16, 2026
@davidhewitt @messense @Hinton
add test case for uniffi with multiple crates (#2839)
0672082 
Closes #1904 

Looks like the issue was fixed by #2208 and #2305 - pushing this test as
a draft to clean up another day.

Co-authored-by: messense <messense@icloud.com>
Co-authored-by: Hinton <hinton@users.noreply.github.com>
@messense messense mentioned this pull request Apr 19, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@messense messense messense approved these changes

Assignees

No one assigned

Labels

bindings/uniffi uniffi bindings

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatMaul @messense