Skip to content

Don't subclass str - #2594

Merged
DanielNoord merged 1 commit into
PyCQA:mainfrom
DanielNoord:line-comments
Jul 23, 2026
Merged

Don't subclass str#2594
DanielNoord merged 1 commit into
PyCQA:mainfrom
DanielNoord:line-comments

Conversation

@DanielNoord

Copy link
Copy Markdown
Member

Taken from #2586

Let's not subclass str as that breaks mypyc and is a bad pattern anyway.

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.30%. Comparing base (68356ea) to head (8cd4629).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2594      +/-   ##
==========================================
- Coverage   99.39%   99.30%   -0.10%     
==========================================
  Files          41       41              
  Lines        3147     3149       +2     
  Branches      680      680              
==========================================
- Hits         3128     3127       -1     
- Misses         11       14       +3     
  Partials        8        8              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DanielNoord
DanielNoord marked this pull request as ready for review July 23, 2026 19:29
@DanielNoord
DanielNoord added this pull request to the merge queue Jul 23, 2026
Merged via the queue into PyCQA:main with commit 6dce56c Jul 23, 2026
24 of 26 checks passed
@DanielNoord
DanielNoord deleted the line-comments branch July 23, 2026 19:32
@DanielNoord DanielNoord mentioned this pull request Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant