Add support for legacy org id#34
Merged
andrew-propelauth merged 2 commits intoFeb 21, 2025
Merged
Conversation
andrew-propelauth
approved these changes
Feb 21, 2025
Contributor
andrew-propelauth
left a comment
andrew-propelauth
left a comment
There was a problem hiding this comment.
Thanks for the contribution! There's one small thing which is the legacyOrgId should be the last argument in the constructor for backwards compatibility reasons, but I'll merge this and add that as a followup commit before releasing. Thanks again!
Contributor
Author
|
Thanks @andrew-propelauth for the feedback, that makes total sense 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the legacy_org_id which then can also be accessed and used in the front-end similar to how it's currently supported in the node library by PropelAuth.