chore: bump version to 4.1.7 - #933
Merged
Merged
Conversation
One bug fix since v4.1.6: the ERC721 fulfillment de-dup key now includes orderIndex (#932), so ERC721 items from different orders can no longer collapse into a single fulfillment component. The rest of the range is dependency updates. Bumped with npm version so package-lock.json stays in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch bump for the one bug fix landed since v4.1.6.
What's in this release
#932 fixes the ERC721 de-duplication key in
generateFulfillOrdersFulfillments. The key was suffixed withitemIndexalone, which separates ERC721s within a single order but not across orders, so two orders sharing offerer (or recipient), token, and identifier at the same item index collapsed into one fulfillment component and Seaport derived a transfer withamount = 2. The suffix is now${orderIndex}-${itemIndex}, which is what the comment above the line has always claimed it did. Reported and fixed by @Sertug17 in #926.That PR also typed the two fulfillment accumulators as arrays, which removed four
as anycasts and means thefulfillAvailableAdvancedOrdersarguments are now checked against the contract ABI rather than cast away. The public signature ofgenerateFulfillOrdersFulfillmentschanged fromFulfillmentComponentStruct[]toFulfillmentComponentStruct[][], but the old annotation never matched what the function returned, so no runtime behavior depended on it.The rest of the range since v4.1.6 is dependency updates: #928, #929, #930, #931.
Notes
Bumped with
npm version patchsopackage-lock.jsonstays in sync. Diff is the two version fields, nothing else.npx hardhat teston this branch: 138 passing.🤖 Generated with Claude Code