chore(deps): update actions/setup-node action to v7 - #920
Conversation
ryanio
left a comment
There was a problem hiding this comment.
Approving. Checks green, and the v7 stability window has passed.
The major bump is driven by setup-node's internal ESM migration, not by any input change — node-version, node-version-file, cache and registry-url all keep their current semantics, so no edits are needed beyond the version.
The one item worth a look was "Remove dummy NODE_AUTH_TOKEN export" (actions/setup-node#1558), since npm-publish.yml sets registry-url and that workflow only runs on release: published — it never gets exercised by PR CI. Checked the upstream rationale:
While this didn't break OIDC flows, it could corrupt the user's
.npmrcby injecting a non-functional token value into the environment, potentially causing confusing behavior during OIDC publish. This PR removes the dummy fallback and only exportsNODE_AUTH_TOKENwhen the user has explicitly set it.
This repo publishes via npm Trusted Publishing — permissions: id-token: write plus npm publish --provenance, with no NODE_AUTH_TOKEN or NPM_TOKEN anywhere in the workflow. So dropping the dummy is neutral-to-beneficial here: nothing depended on the placeholder, and the .npmrc written alongside the OIDC exchange is now cleaner.
The three main.yaml jobs did run on v7 in this PR's own CI and passed, which covers the node-version: 24.x + cache: npm path directly. npm-publish.yml stays unverified until a release is cut, so that is the thing to keep an eye on next publish.
This PR contains the following updates:
v6→v7Release Notes
actions/setup-node (actions/setup-node)
v7.0.0Compare Source
What's Changed
Enhancements:
Bug fixes:
mirrorTokeningetManifestif it's provided by @deiga in #1548Documentation updates:
Dependency update:
New Contributors
Full Changelog: actions/setup-node@v6...v7.0.0
v7Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.