Skip to content

Small refactoring in effect metadata - #4782

Closed
TimvdLippe wants to merge 18 commits into
masterfrom
pre-built-effects
Closed

Small refactoring in effect metadata#4782
TimvdLippe wants to merge 18 commits into
masterfrom
pre-built-effects

Conversation

@TimvdLippe

Copy link
Copy Markdown
Contributor

Refactor effect metadata system with a couple of modifications:

  • Add fallback for when data does not exist. This is primarily the start for Implement build time optimizations #4137 and potential later changes to choose better defaults to reduce memory
  • Factor out the effect functions from property-effects. This is primarily a readibility improvement.
  • Rewrite findTemplateNode to operate on an array instead of nested objects. This stores significantly less information in a compressed format.

Reference Issue

These are preparations #4137

@TimvdLippe

Copy link
Copy Markdown
Contributor Author

As this PR grew big over time, I am factoring out some of the sub-changes. This makes reviewing easier and make sure that the changes are not all-or-nothing, but pick those that we like.

I extracted the findTemplateNode change to #4853

@sorvell sorvell added the 3.x label Oct 3, 2017
@sorvell

sorvell commented Oct 3, 2017

Copy link
Copy Markdown
Contributor

Since there are potentially breaking changes in this PR, we are likely to consider it for Polymer 3.x.

@TimvdLippe

Copy link
Copy Markdown
Contributor Author

Closing the PR for now, but keeping the branch alive. We will revisit this for Polymer 3.

@TimvdLippe TimvdLippe closed this Dec 1, 2017
@TimvdLippe
TimvdLippe deleted the pre-built-effects branch June 26, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants