Skip to content
This repository was archived by the owner on May 1, 2019. It is now read-only.

Fix parsing of non-primitive Expressions - #725

Merged
rictic merged 4 commits into
masterfrom
fix-behavior-merging
Oct 27, 2017
Merged

Fix parsing of non-primitive Expressions#725
rictic merged 4 commits into
masterfrom
fix-behavior-merging

Conversation

@TimvdLippe

Copy link
Copy Markdown
Contributor

This came up during parsing of
https://github.com/PolymerElements/iron-form-element-behavior/blob/6087b69013619e5b3e023a10824d25cf7530d1fc/iron-form-element-behavior.html#L74-L84 where conditionals are used instead of direct assignments.

  • CHANGELOG.md has been updated

@TimvdLippe
TimvdLippe requested a review from rictic September 6, 2017 03:16
@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@rictic
rictic merged commit aae0cb8 into master Oct 27, 2017
@rictic
rictic deleted the fix-behavior-merging branch October 27, 2017 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants