Skip to content

test(regression): #915 — standalone + Fastify async-route jwt.sign tests - #926

Merged
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/fix-jwt-sign-native-dispatch
May 17, 2026
Merged

test(regression): #915 — standalone + Fastify async-route jwt.sign tests#926
proggeramlug merged 1 commit into
PerryTS:mainfrom
andrewtdiz:codex/fix-jwt-sign-native-dispatch

Conversation

@andrewtdiz

@andrewtdiz andrewtdiz commented May 17, 2026

Copy link
Copy Markdown
Contributor

Summary

The original codegen fix for #915 landed via PR #920 (fix(codegen): #915 — jwt.sign(...) dispatch calling-convention mismatch SIGSEGVed after async resume, commit ccf96c26) which took a more general approach using NativeArgKind::JsonStringify lowering.

This PR has been rebased to keep only the two regression tests authored here, since they strengthen the regression net beyond what #920's test covers:

Verification

  • Standalone test compiles + runs against current main: object token typeof: string, string token typeof: string, exit 0.
  • Fastify test requires fastify + jsonwebtoken installed; covered by existing test infrastructure.
  • Cherry-picked from this PR's original commit, then dropped the now-redundant codegen changes (since fix(codegen): #915 — jwt.sign(...) NATIVE_MODULE_TABLE calling-convention SIGSEGV #920 fixes the underlying bug with a more general dispatch).

Closes #915 (test coverage half — codegen half closed by #920).

Note to author

Thank you @andrewtdiz — your diagnosis caught the same calling-convention mismatch our fix-agent found independently. Keeping your two test files as additional pinning since they cover shapes our regression doesn't.

@proggeramlug proggeramlug changed the title Fix jsonwebtoken.sign native ABI lowering test(regression): #915 — standalone + Fastify async-route jwt.sign tests May 17, 2026
@proggeramlug
proggeramlug merged commit 900e09b into PerryTS:main May 17, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native server SIGSEGV at jwt.sign(...) (jsonwebtoken) after resumed async-step body — follow-up to #859

2 participants