test(regression): #915 — standalone + Fastify async-route jwt.sign tests - #926
Merged
proggeramlug merged 1 commit intoMay 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The original codegen fix for #915 landed via PR #920 (
fix(codegen): #915 — jwt.sign(...) dispatch calling-convention mismatch SIGSEGVed after async resume, commitccf96c26) which took a more general approach usingNativeArgKind::JsonStringifylowering.This PR has been rebased to keep only the two regression tests authored here, since they strengthen the regression net beyond what #920's test covers:
test-files/test_issue_915_jwt_sign.ts— pins the basicjwt.sign({sub:'x'}, 'secret')+ string-payload shape standalone (no async, no Fastify).test-files/test_issue_915_jwt_sign_after_async_route.ts— pins the Fastify async-route shape (nested async function before jwt.sign), matching the original Native server SIGSEGV atjwt.sign(...)(jsonwebtoken) after resumed async-step body — follow-up to #859 #915 minimal repro.Verification
object token typeof: string,string token typeof: string, exit 0.fastify+jsonwebtokeninstalled; covered by existing test infrastructure.Closes #915 (test coverage half — codegen half closed by #920).
Note to author
Thank you @andrewtdiz — your diagnosis caught the same calling-convention mismatch our fix-agent found independently. Keeping your two test files as additional pinning since they cover shapes our regression doesn't.