Skip to content

style: rustfmt after #7434 - #7442

Merged
proggeramlug merged 1 commit into
mainfrom
fix/fmt-after-7434
Aug 5, 2026
Merged

style: rustfmt after #7434#7442
proggeramlug merged 1 commit into
mainfrom
fix/fmt-after-7434

Conversation

@proggeramlug

@proggeramlug proggeramlug commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

cargo fmt --all -- --check fails on main (exit 1) after #7434.

lint is a required context, so while it is red every merge bypasses a required gate — the exact hazard CLAUDE.md's gate list describes, and it is how a 2000-line cap violation went unnoticed for 40 commits earlier today.

Two hunks, six lines:

  • gc/tests/telemetry_verifier.rs:396 — an assert! 72 columns from col 4, over rustfmt's default fn_call_width of 60
  • object/field_get_set.rs:192pub(crate) use ic_miss::pic_epoch_bump; added below the pub use ic_miss::{…} block; reorder_imports wants it above

Not a toolchain artifact: CI uses dtolnay/rust-toolchain@stable, and the repo has no rust-toolchain.toml or rustfmt.toml.

My miss — I merged #7434 without running cargo fmt --check first.

Summary by CodeRabbit

  • Bug Fixes

    • Corrected formatting issues so automated formatting checks now pass consistently.
    • Reorganized import ordering and reformatted a long assertion without changing runtime behavior.
  • Documentation

    • Updated the changelog to document the formatting fix and its impact on lint checks.

proggeramlug pushed a commit that referenced this pull request Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 52efeb0a-4ce8-4d4f-9662-09e961717d52

📥 Commits

Reviewing files that changed from the base of the PR and between 145fa02 and 51bee08.

📒 Files selected for processing (3)
  • changelog.d/7442-fmt-after-7434.md
  • crates/perry-runtime/src/gc/tests/telemetry_verifier.rs
  • crates/perry-runtime/src/object/field_get_set.rs

📝 Walkthrough

Walkthrough

The PR reformats a telemetry assertion, reorders a crate-private re-export, and adds a changelog entry. No behavior or public declarations change.

Changes

Rust formatting fixes

Layer / File(s) Summary
Runtime formatting and changelog
crates/perry-runtime/src/gc/tests/telemetry_verifier.rs, crates/perry-runtime/src/object/field_get_set.rs, changelog.d/7442-fmt-after-7434.md
The telemetry assertion uses multiline formatting. The pic_epoch_bump re-export moves before the other ic_miss re-exports. The changelog documents both fixes.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • PerryTS/perry#6724: Both PRs apply rustfmt-only formatting fixes to Perry runtime code.
  • PerryTS/perry#7042: Both PRs address cargo fmt --all -- --check backlog items.
  • PerryTS/perry#7180: Both PRs make Rust formatting fixes in perry-runtime to satisfy lint and fmt checks.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/fmt-after-7434

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

cargo fmt --all -- --check failed on main. lint is a REQUIRED context,
so while it is red every merge bypasses a required gate.

Two hunks, six lines: an assert! in gc/tests/telemetry_verifier.rs over
rustfmt's default fn_call_width of 60, and a pub(crate) use in
object/field_get_set.rs added below the pub use block where
reorder_imports wants it above.

Not a toolchain artifact: CI uses dtolnay/rust-toolchain@stable and the
repo has no rust-toolchain.toml or rustfmt.toml.
@proggeramlug
proggeramlug merged commit 73c7118 into main Aug 5, 2026
7 of 11 checks passed
@proggeramlug
proggeramlug deleted the fix/fmt-after-7434 branch August 5, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant