style: rustfmt after #7434 - #7442
Merged
Merged
Conversation
proggeramlug
pushed a commit
that referenced
this pull request
Aug 5, 2026
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe PR reformats a telemetry assertion, reorders a crate-private re-export, and adds a changelog entry. No behavior or public declarations change. ChangesRust formatting fixes
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cargo fmt --all -- --check failed on main. lint is a REQUIRED context, so while it is red every merge bypasses a required gate. Two hunks, six lines: an assert! in gc/tests/telemetry_verifier.rs over rustfmt's default fn_call_width of 60, and a pub(crate) use in object/field_get_set.rs added below the pub use block where reorder_imports wants it above. Not a toolchain artifact: CI uses dtolnay/rust-toolchain@stable and the repo has no rust-toolchain.toml or rustfmt.toml.
proggeramlug
force-pushed
the
fix/fmt-after-7434
branch
from
August 5, 2026 11:59
90edefd to
51bee08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmt --all -- --checkfails onmain(exit 1) after #7434.lintis a required context, so while it is red every merge bypasses a required gate — the exact hazard CLAUDE.md's gate list describes, and it is how a 2000-line cap violation went unnoticed for 40 commits earlier today.Two hunks, six lines:
gc/tests/telemetry_verifier.rs:396— anassert!72 columns from col 4, over rustfmt's defaultfn_call_widthof 60object/field_get_set.rs:192—pub(crate) use ic_miss::pic_epoch_bump;added below thepub use ic_miss::{…}block;reorder_importswants it aboveNot a toolchain artifact: CI uses
dtolnay/rust-toolchain@stable, and the repo has norust-toolchain.tomlorrustfmt.toml.My miss — I merged #7434 without running
cargo fmt --checkfirst.Summary by CodeRabbit
Bug Fixes
Documentation