Skip to content

fix(runtime): explicit gc() runs a full collection so dead old-gen objects are reclaimed #5714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheHypnoo merged 1 commit into from
Jun 26, 2026
Merged

fix(runtime): explicit gc() runs a full collection so dead old-gen objects are reclaimed #5714

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/perry-runtime/src/gc/policy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1560,7 +1560,15 @@ pub extern "C" fn js_gc_collect() {
fn manual_gc_collect_now() {
let _scan = super::roots::ManualGcScanGuard::force_full_scan();
crate::weakref::clear_pending_finalization_jobs();
gc_collect_inner_with_trigger(GcTriggerSnapshot::capture(GcTriggerKind::Manual))
// An explicit `gc()` runs a FULL mark-sweep rather than the generational
// fast path. With gen-GC on (the default), `gc_collect_inner_with_trigger`
// dispatches a MINOR cycle, whose sweep skips dead-old-block reclamation
// (`reclaim_dead_old_blocks = false`) — so dead large/tenured objects (which
// are born in the old arena, >16 KB) survived an explicit `gc()` and RSS
// never dropped. A full cycle reclaims them, matching V8/Node `--expose-gc`
// semantics where `gc()` is a full collection. Automatic threshold-driven
// minors are unaffected.
gc_collect_full_mark_sweep_with_trigger(GcTriggerSnapshot::capture(GcTriggerKind::Manual))
.emit_after_current();
crate::weakref::queue_pending_finalization_callbacks_after_gc();
}
Expand Down
Loading