Split crypto stdlib modules - #1808
Merged
Merged
Conversation
TheHypnoo
marked this pull request as ready for review
May 25, 2026 18:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crates/perry-stdlib/src/crypto.rsinto smaller topical Rust submodules undercrates/perry-stdlib/src/crypto/.crates/perry-stdlib/src/webcrypto.rsinto smaller topical Rust submodules undercrates/perry-stdlib/src/webcrypto/.Notes
This keeps the existing public
cryptoandwebcryptomodule surfaces intact: the top-level entry files now declare real sibling modules, importpub(super)helpers privately for cross-shard use, and publicly re-export the FFI entry points / public handles from the topical shards.The former
include!approach was replaced in this PR, so the split now follows the file-size script guidance more closely: each shard is a real Rust module with its own namespace and compilation unit while preserving the existing#[no_mangle]FFI symbols and parent-module re-export surface.util.rsin each tree owns the shared imports, helpers, and private types; those are intentionally visible only to sibling shards through the parent module.Closes #1435.
Validation
./scripts/check_file_size.shcargo fmt --checkcargo check -p perry-stdlibcargo build --release -p perry-stdlib