lint is a required check and it has been failing on main since 83a6767ff ("GC memory: shape-key typed layouts (#6893) + major-GC pacing; don't link CoreFoundation in every binary (#6939)"). The failing step is Check formatting (cargo fmt --all -- --check); every step after it in the job is skipped, so Audit workspace architecture, Public benchmark evidence freshness, File size limit, GC store-site inventory and Address-classification audit are not running at all right now.
Because it is a required context, this reds every open PR regardless of that PR's contents. Noticed on #6954, whose diff contains zero .rs files.
Repro
$ git checkout main && git log --oneline -1
83a6767ff GC memory: shape-key typed layouts (#6893) + major-GC pacing; …
$ cargo fmt --all -- --check
Two hunks, both in files last touched by 83a6767ff:
Diff in crates/perry-runtime/src/gc/mod.rs:135:
- let outcome = gc_collect_full_mark_sweep_with_trigger(GcTriggerSnapshot::capture(trigger.kind));
+ let outcome =
+ gc_collect_full_mark_sweep_with_trigger(GcTriggerSnapshot::capture(trigger.kind));
Diff in crates/perry-runtime/src/temporal/now.rs:9:
use super::{alloc_temporal_cell, TemporalValue};
use temporal_rs::host::{HostClock, HostHooks, HostTimeZone};
+use temporal_rs::now::Now;
use temporal_rs::provider::TimeZoneProvider;
use temporal_rs::unix_time::EpochNanoseconds;
-use temporal_rs::now::Now;
Fix is cargo fmt --all on main. Filing rather than folding it into an unrelated PR, since the fix belongs on main — patching it in one branch would unblock only that branch while every other PR stays red.
Worth a look at how it landed green: 83a6767ff is on main, so either the check was bypassed or it was already red when that PR merged.
lintis a required check and it has been failing onmainsince83a6767ff("GC memory: shape-key typed layouts (#6893) + major-GC pacing; don't link CoreFoundation in every binary (#6939)"). The failing step isCheck formatting(cargo fmt --all -- --check); every step after it in the job is skipped, soAudit workspace architecture,Public benchmark evidence freshness,File size limit,GC store-site inventoryandAddress-classification auditare not running at all right now.Because it is a required context, this reds every open PR regardless of that PR's contents. Noticed on #6954, whose diff contains zero
.rsfiles.Repro
Two hunks, both in files last touched by
83a6767ff:Fix is
cargo fmt --allonmain. Filing rather than folding it into an unrelated PR, since the fix belongs onmain— patching it in one branch would unblock only that branch while every other PR stays red.Worth a look at how it landed green:
83a6767ffis onmain, so either the check was bypassed or it was already red when that PR merged.