Skip to content

Extra exception logging for SQL throughput collection #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidBoike wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extra exception logging for SQL throughput collection #5507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Particular.LicensingComponent/BrokerThroughput/BrokerThroughputCollectorHostedService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,16 @@ async Task Exec(IBrokerQueue queueName, string postfix)

await foreach (var queueThroughput in brokerThroughputQuery.GetThroughputPerDay(queueName, startDate, stoppingToken))
{
await dataStore.RecordEndpointThroughput(queueName.QueueName, ThroughputSource.Broker, queueThroughput.DateUTC, queueThroughput.TotalThroughput, stoppingToken);
try
{
await dataStore.RecordEndpointThroughput(queueName.QueueName, ThroughputSource.Broker, queueThroughput.DateUTC, queueThroughput.TotalThroughput, stoppingToken);
}
catch (Exception e)
{
logger.LogError(e, "Failed to record throughput for {QueueName}", queueName.QueueName);
Console.WriteLine(e);
throw;
}
}
}
}
Expand Down
26 changes: 22 additions & 4 deletions src/ServiceControl.Transports.SqlServer/SqlServerQuery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,15 +60,33 @@ public override async IAsyncEnumerable<QueueThroughput> GetThroughputPerDay(IBro
[EnumeratorCancellation] CancellationToken cancellationToken = default)
{
var queueTableName = (BrokerQueueTable)brokerQueue;
var startData =
await queueTableName.DatabaseDetails.GetSnapshot(queueTableName, cancellationToken);

BrokerQueueTableSnapshot startData;
try
{
startData = await queueTableName.DatabaseDetails.GetSnapshot(queueTableName, cancellationToken);
}
catch (Exception e)
{
logger.LogError(e, "Failed to query throughput starting snapshot for {QueueName}", queueTableName.QueueName);
throw;
}

// looping for 24 hours
for (var i = 0; i < 24; i++)
{
await Task.Delay(TimeSpan.FromHours(1), timeProvider, cancellationToken);
var endData =
await queueTableName.DatabaseDetails.GetSnapshot(queueTableName, cancellationToken);

BrokerQueueTableSnapshot? endData;
try
{
endData = await queueTableName.DatabaseDetails.GetSnapshot(queueTableName, cancellationToken);
}
catch (Exception e)
{
logger.LogError(e, "Failed to query throughput hour {hour} for {QueueName}", i, queueTableName.QueueName);
throw;
}

if (endData.RowVersion.HasValue && startData.RowVersion.HasValue)
{
Expand Down
Loading