Check writing of initial values of sampled Variables - #2622
Open
erikvansebille wants to merge 8 commits into
Open
Check writing of initial values of sampled Variables#2622erikvansebille wants to merge 8 commits into
erikvansebille wants to merge 8 commits into
Conversation
erikvansebille
marked this pull request as ready for review
July 28, 2026 15:01
j-atkins
reviewed
Jul 29, 2026
j-atkins
left a comment
j-atkins
left a comment
There was a problem hiding this comment.
Looks good, a nice explanation! Just some tiny comments below
Member
Author
Thanks! All addressed in 2c2dd98 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #2619, there is a bug in that the initial values of sampled Variables are not in the particle file. This PR provides a (failing) unit test to show that
Checklist
mainfor normal development,v3-supportfor v3 support)AI Disclosure
None