Conversation
MarkBaker
commented
Nov 20, 2018
Member
Author
|
Need to enforce "doctrine/instantiator": "1.0.5" in composer.json (or ^1.0.0) for PHP 5.6; doctrine/instantiator 1.1.0 (if allowed) will break unit tests against PHP 5.6... composer should handle ^1.0.0 correctly when running on travis against 5.6 |
PowerKiKi
reviewed
Nov 20, 2018
PowerKiKi
left a comment
Member
There was a problem hiding this comment.
should probably use lowercase method name
Co-Authored-By: MarkBaker <mark@lange.demon.co.uk>
Co-Authored-By: MarkBaker <mark@lange.demon.co.uk>
MarkBaker
commented
Nov 20, 2018
1 task
BlackyTay
pushed a commit
to BlackyTay/PhpSpreadsheet
that referenced
this pull request
Aug 8, 2025
Changes to the xml security scanner to use libxml_disable_entity_loader() when cleanly supported and thread-safe, and to handle UTF-7 charset which otherwise permits an XXE exploit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is:
Checklist:
Why this change is needed?
Changes to the xml security scanner to use
libxml_disable_entity_loader()when cleanly supported and thread-safe, and to handle UTF-7 charset which otherwise permits an XXE exploit