Dev

[matteoettam09]

Summary by CodeRabbit

• New Features
  • Added BuyingLeg entry-buffer snapshot (buyingLegEntryBuffer) for improved epoch accounting.
• Updates
  • Renamed token-decimals config getter to tokenDecimals (removed getTokenDecimals), and updated vault adapters/pricing accordingly.
  • Deposit eligibility checks now accept request-specific call data in access-control flows.
• Bug Fixes
  • Improved epoch-end gating and finalization after vault operations, including minibatch progression edge cases.
• Tests
  • Added epoch-end transition coverage and updated adapter/decimals validation expectations.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 082b5bf1-ca03-4cf3-8beb-9dd4463211ac

📥 Commits

Reviewing files that changed from the base of the PR and between d7654ba and efccb99.

📒 Files selected for processing (1)

• .github/workflows/ci.yml

💤 Files with no reviewable changes (1)

• .github/workflows/ci.yml

---

📝 Walkthrough

Walkthrough

The PR updates LiquidityOrchestrator epoch accounting and finalization, renames the token-decimals accessor, passes deposit calldata to access control, adds epoch-end tests, and updates package and CI tooling.

Changes

Protocol behavior

Layer / File(s)	Summary
Orchestrator epoch transitions contracts/LiquidityOrchestrator.sol, contracts/interfaces/ILiquidityOrchestrator.sol, contracts/test/LiquidityOrchestratorHarness.sol, test/LiquidityOrchestratorEpochEnd.test.ts	BuyingLeg buffer accounting is added, epoch finalization is gated on Idle, and tests cover completion, intermediate minibatches, and index wrapping.
Token-decimal accessor migration contracts/interfaces/IOrionConfig.sol, contracts/OrionConfig.sol, contracts/execution/..., contracts/price/..., contracts/test/..., test/crossAsset/...	The decimals accessor is renamed to tokenDecimals, with adapters, mocks, and cross-asset tests updated.
Deposit access-control context contracts/interfaces/IOrionAccessControl.sol, contracts/access_controllers/WhitelistAccessControl.sol, contracts/vaults/OrionVault.sol	Deposit authorization accepts request data, and both vault checks pass msg.data.

Tooling updates

Layer / File(s)	Summary
Package and workspace configuration package.json, pnpm-workspace.yaml	Package metadata and development tools are updated, pnpm is pinned, and workspace dependency rules are added.
CI checkout actions .github/workflows/ci.yml	Checkout is upgraded from v6 to v7 in three jobs, and explicit pnpm action versions are removed.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant UpkeepCaller
  participant LiquidityOrchestrator
  participant VaultOperations
  participant EpochState
  participant EventsLib
  UpkeepCaller->>LiquidityOrchestrator: performUpkeep
  LiquidityOrchestrator->>VaultOperations: process vault-operation minibatch
  VaultOperations->>EpochState: advance minibatch and phase
  EpochState-->>LiquidityOrchestrator: transition to Idle
  LiquidityOrchestrator->>EventsLib: emit EpochEnd

Loading

Possibly related PRs

• OrionFinanceAI/protocol#68: Also changes LiquidityOrchestrator phase and minibatch handling.
• OrionFinanceAI/protocol#130: Also updates LiquidityOrchestrator epoch transition logic.
• OrionFinanceAI/protocol#199: Also modifies epoch-end handling and failed-token cleanup.

Poem

A bunny tracks the buffer bright,
Through selling’s dusk to buying’s light.
Minibatches hop, then epochs end,
With calldata carried round the bend.
New tools keep CI spry and neat!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is generic and doesn't describe the actual changes in the pull request.	Replace it with a concise summary of the main change, such as the key contract, config, or test update.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dev

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Line 16: Update all three actions/checkout uses in the CI workflow to
reference the same appropriate full immutable commit SHA instead of the movable
v7 tag, including the checkout steps near lines 16, 71, and 112.

In `@contracts/price/ERC4626PriceAdapter.sol`:
- Line 67: Update the zero-supply return in the ERC4626 price calculation to use
the same immutable underlying-token decimals as the non-empty path, rather than
CONFIG.tokenDecimals(vaultUnderlying). Preserve the existing PRICE_DECIMALS
offset and zero-supply behavior.

In `@contracts/test/LiquidityOrchestratorHarness.sol`:
- Around line 92-96: Do not simulate an impossible uint8 cursor wrap. In
contracts/test/LiquidityOrchestratorHarness.sol lines 92-96, remove the
unchecked increment and either enforce the production batch limit or widen the
cursor consistently with production. In
test/LiquidityOrchestratorEpochEnd.test.ts lines 190-204, replace the wrap
assertion with coverage proving the selected batch-limit or widened-cursor
behavior, while preserving the production behavior implemented around the
LiquidityOrchestrator cursor increment.

In `@package.json`:
- Line 90: Update the pnpm/action-setup configuration in all three jobs within
ci.yml to honor the packageManager pnpm 11.10.0 pin: either remove each explicit
version setting or change all three to the matching pnpm 11.10.0 version,
keeping the repository and CI versions consistent.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d2e54a95-2c7a-45f0-827d-ce292314bf8b

📥 Commits

Reviewing files that changed from the base of the PR and between 0737f0d and d7654ba.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (20)

• .github/workflows/ci.yml
• contracts/LiquidityOrchestrator.sol
• contracts/OrionConfig.sol
• contracts/access_controllers/WhitelistAccessControl.sol
• contracts/execution/ERC4626ExecutionAdapter.sol
• contracts/interfaces/ILiquidityOrchestrator.sol
• contracts/interfaces/IOrionAccessControl.sol
• contracts/interfaces/IOrionConfig.sol
• contracts/price/ERC4626PriceAdapter.sol
• contracts/test/LiquidityOrchestratorHarness.sol
• contracts/test/MockERC4626PriceAdapter.sol
• contracts/test/MockOrionConfig.sol
• contracts/vaults/OrionVault.sol
• package.json
• pnpm-workspace.yaml
• test/LiquidityOrchestratorEpochEnd.test.ts
• test/crossAsset/ERC4626ExecutionAdapter.atomic.test.ts
• test/crossAsset/ERC4626ExecutionAdapter.test.ts
• test/crossAsset/ERC4626PriceAdapter.test.ts
• test/crossAsset/MorphoBlueSupplyVault.test.ts

💤 Files with no reviewable changes (2)

• test/crossAsset/ERC4626ExecutionAdapter.atomic.test.ts
• contracts/OrionConfig.sol