B33

[matteoettam09]

Summary by CodeRabbit

• Bug Fixes

  • Asset fee-tier updates are now blocked when the system is not idle.

• Chores

  • Version bumped to 2.3.3.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f7ea9fff-0c57-453f-8244-e27f000dc610

📥 Commits

Reviewing files that changed from the base of the PR and between 07a2739 and c6c7c77.

📒 Files selected for processing (2)

• contracts/test/MockOrionConfig.sol
• package.json

---

📝 Walkthrough

Walkthrough

This pull request adds a system-idle guard to the UniswapV3ExecutionAdapter's setAssetFee method to prevent fee-tier updates when the system is active, accompanied by a mock implementation of isSystemIdle() for testing. Version updated to 2.3.3.

Changes

Cohort / File(s)	Summary
System Idle Guard Implementation contracts/execution/UniswapV3ExecutionAdapter.sol, contracts/test/MockOrionConfig.sol	Added isSystemIdle() validation in setAssetFee to revert with SystemNotIdle() error when system is not idle. Implemented mock support with systemIdle state variable, getter, and setter for testing.
Version Bump package.json	Incremented package version from 2.3.2 to 2.3.3.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related issues

• OrionFinanceAI/protocol-bug-bounty#33: Directly implements the recommended isSystemIdle() guard on UniswapV3ExecutionAdapter.setAssetFee to address the fee-tier update vulnerability during active trading.

Possibly related PRs

• B11 #201: Also adds config.isSystemIdle() gating with ErrorsLib.SystemNotIdle() reversion to execution/submission functions for consistent system safety checks.

Poem

🐰 A guard so fine, when systems run fast,
No fees shall shift while trades hold vast,
The rabbit checks: "Is all idle, pray?"
If not, the update must wait its day! 🏃‍♂️✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'B33' appears to be a branch or ticket identifier with no descriptive information about the actual changes in the pull request.	Replace the title with a descriptive summary of the main changes, such as 'Add system idle check to setAssetFee and update MockOrionConfig' or 'Block fee-tier updates when system is not idle'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch b33

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}