[DebugMod] Actor select via NPC Menu highlights them in world (and vice versa)#133
Conversation
* NPC name filter works better * Clicking on an NPC in the list, will show their bound boxes in the world * Modernised some code (make it less C-like) * Added nullptr checks * New substring searching function that take a string * Refactored code * Better handling on int and chars * Fixed crash when clicking Scene Menu
|
Hey, while you are already at editing the Debug mod, do you think you could also implement a fix for #117 in your PR? Someone already proposed some code changes there which look good to me: #117 (comment) |
Yeah sure thing |
* An selected entity will now be deslected if selected again * Const some vars * Made some function static
OrfeasZ
left a comment
OrfeasZ
left a comment
There was a problem hiding this comment.
Left a couple of minor notes. Otherwise looks good!
Thanks :) |
* Remove redundant exception handling
HRSoftware
changed the title
|
@HRSoftware I see you've merged master into this. Is this ready to be merged back? |
Not yet - I need to remove some stray changes. Will update when I get round to doing that :) |
* Whitespace * Renamed variables * const'd function
* Renamed var * Changed var type
# Conflicts: # ZHMModSDK/Include/Glacier/ZActor.h
|
@OrfeasZ - I'm done for this PR (bar any additional changes you or others want) - good to re-review/approve :) |
|
LGTM! |
3 participants
NPC Menu and world are now in sync when the user selects a character via the NPC menu, or by selecting them in the world.
Other improvements: