Context
Both GitLab and GitHub support multi-line inline comments, but we only anchor to a single line.
- GitLab:
position.line_range with start.new_line / end.new_line
- GitHub:
start_line + line fields in review comments
E9 Concerns
Asking the model for TWO line numbers per finding doubles the hallucination surface. Need validation that end_line >= line and both are within the diff hunk.
Defer until after dogfooding. Ship single-line first. Add multi-line when real usage data shows users want it.
Changes Required
Finding.EndLine field in model output
ReviewComment.EndLine in VCS types
- Prompt schema update to request
end_line
- Validation:
end_line >= line, both in diff range
- GitLab:
line_range in position
- GitHub:
start_line in review comment
- Suggestion offset: GitLab
suggestion:-N+M syntax
Ref
E9 design session in conversation 8ecd8c13
Context
Both GitLab and GitHub support multi-line inline comments, but we only anchor to a single line.
position.line_rangewithstart.new_line/end.new_linestart_line+linefields in review commentsE9 Concerns
Changes Required
Finding.EndLinefield in model outputReviewComment.EndLinein VCS typesend_lineend_line >= line, both in diff rangeline_rangein positionstart_linein review commentsuggestion:-N+MsyntaxRef
E9 design session in conversation
8ecd8c13