Context
Currently CleanPreviousReviews deletes all old bot comments. This destroys review history.
GitLab supports resolving discussion threads (PUT /discussions/:id { resolved: true }), which collapses them instead of removing them. Users can still see previous review feedback.
Proposed Changes
- Add
cleanup_mode config field: resolve | delete (default: delete for backward compat)
- GitLab: resolve bot discussions via
PUT /discussions/:id
- GitHub: keep delete behavior (no thread resolution via REST API)
- Delete bot summary notes (non-discussion notes can't be resolved)
E9 Note
Resolve-instead-of-delete is a silent behavior change. Must be opt-in, not a default flip.
Ref
E9 design session in conversation 8ecd8c13
Context
Currently
CleanPreviousReviewsdeletes all old bot comments. This destroys review history.GitLab supports resolving discussion threads (
PUT /discussions/:id { resolved: true }), which collapses them instead of removing them. Users can still see previous review feedback.Proposed Changes
cleanup_modeconfig field:resolve|delete(default:deletefor backward compat)PUT /discussions/:idE9 Note
Ref
E9 design session in conversation
8ecd8c13