Skip to content

Several fixes regarding rules#68

Merged
Mariosmsk merged 4 commits into
OpenWaterAnalytics:devfrom
andreArtelt:dev
Jan 9, 2025
Merged

Several fixes regarding rules#68
Mariosmsk merged 4 commits into
OpenWaterAnalytics:devfrom
andreArtelt:dev

Conversation

@andreArtelt

Copy link
Copy Markdown
Contributor

This pull request addresses two issues regarding rules:

  • Fixing a datetime deprecation warning in getRules and removing the time zone from the string. Note that 1) the time zone is not required and does not make any sense, and 2) it violates the EPANET rule formatting.
  • Fixing a bug in __controlSettings for parsing clock times. This fix ensures that PM clock times are processed correctly.

I need this bugfix for the next release of EPyT-Flow -- would be great if you could create a new release of EPyT.

Many thanks and best wishes,
André

@Mariosmsk

Copy link
Copy Markdown
Member

Hi @andreArtelt, Happy New Year! 🎉

I have made some changes based on your suggestions. Please test the code and let me know if it works.

@andreArtelt

Copy link
Copy Markdown
Contributor Author

Works for me.
I think specifying the timezone is not necessary but also does not hurt xD

Thanks!

@Mariosmsk

Copy link
Copy Markdown
Member

I think specifying the timezone is not necessary but also does not hurt xD

Thank you! I think we need to avoid confusion about what the user needs to set.

Example:

without UTC:
image

with UTC:
image

I am closing this issue!

@Mariosmsk Mariosmsk closed this Jan 9, 2025
@Mariosmsk Mariosmsk reopened this Jan 9, 2025
@Mariosmsk
Mariosmsk merged commit 16df7a5 into OpenWaterAnalytics:dev Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants