Anchor pre-release regex on end of string - #96
Merged
Conversation
This commit makes a small change to the regex for determining when to build a pre-release to anchor on the end of the string. This means that only full git tags, such as `9.0.0-beta1`, will be matched and not git describe output for releases between tags, like: `9.0.0-beta1-9-g347642bbe` Proper test coverage for version munging is also added. Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
Sharpie
enabled auto-merge
July 17, 2026 14:50
bastelfreak
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This commit makes a small change to the regex for determining when to build a pre-release to anchor on the end of the string. This means that only full git tags, such as
9.0.0-beta1, will be matched and not git describe output for releases between tags, like:9.0.0-beta1-9-g347642bbeProper test coverage for version munging is also added.
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent