Properly ignore first col of tables in scrape_term#74
Merged
madhavarshney merged 1 commit intoMay 23, 2020
Merged
Conversation
phi-line
reviewed
May 23, 2020
| rows = t.find_all('tr', {'class': 'CourseRow'}) | ||
| s = defaultdict(lambda: defaultdict(list)) | ||
| for tr in rows: | ||
| cols = tr.find_all(lambda tag: tag.name == 'td' and not tag.get_text().isspace()) |
madhavarshney
commented
May 23, 2020
|
|
||
| try: | ||
| key = get_key(f'{cols[0] if cols[0] else cols[1]}')[0] | ||
| key = get_key(cols[0])[0] |
Member
Author
There was a problem hiding this comment.
Oh wait, not sure if this is necessary / what it breaks.
Collaborator
There was a problem hiding this comment.
I think this is okay now because you popped the first.
Can you test locally to see if it returns a desired result?
Member
Author
There was a problem hiding this comment.
According to my testing, it seems to work fine. (Tested with LiveMyPortalData)
phi-line
requested changes
May 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.