Add precompiles for Multi-Constraint Pricer#3860
Merged
Merged
Conversation
Contributor
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
6ab7990 to
60168e0
Compare
60168e0 to
708fcd3
Compare
gligneul
requested changes
Oct 17, 2025
gligneul
reviewed
Oct 17, 2025
93ea3ac to
b1a7d62
Compare
gligneul
previously approved these changes
Oct 20, 2025
This was referenced Oct 20, 2025
eljobe
reviewed
Oct 20, 2025
2fb45db to
d1d0e7d
Compare
eljobe
requested changes
Oct 24, 2025
| // Each new precompile contract and each method on new or existing precompile | ||
| // contracts should be counted. | ||
| expectedNewEntriesPerArbosVersion := map[uint64]int{ | ||
| 0: 102, |
Member
There was a problem hiding this comment.
I'm surprised to see this drop from 102 to 99.
Where did the 3 precompiles that were available since version 0 go?
I wouldn't expect this to change over time.
Contributor
There was a problem hiding this comment.
There was another PR that included the changes in nitro-precompiles-interfaces, and committed to master the new precompiles as if they were from version 0. This is just fixing that (and we should fix this before releasing a version).
d1d0e7d to
117c152
Compare
117c152 to
f643023
Compare
eljobe
approved these changes
Oct 24, 2025
gligneul
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NIT-4021 and NIT-4024
Depends on:
(first iteration)
(second iteration)
Changes:
contracts-local/srcon "Add precompile interfaces for Multi-Constraint Pricer"