Skip to content

Add precompiles for Multi-Constraint Pricer#3860

Merged
eljobe merged 16 commits into
masterfrom
add-precompiles-for-multi-constraint-pricer
Oct 24, 2025
Merged

Add precompiles for Multi-Constraint Pricer#3860
eljobe merged 16 commits into
masterfrom
add-precompiles-for-multi-constraint-pricer

Conversation

@MishkaRogachev

@MishkaRogachev MishkaRogachev commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

Fixes NIT-4021 and NIT-4024
Depends on:

(first iteration)

(second iteration)

Changes:

  • Update contracts-local/src on "Add precompile interfaces for Multi-Constraint Pricer"
  • Implement Multi-Constraint Pricer precompiles
  • Add precompiles unit test for constraints management
  • Enable Multi-Constraint Pricer for ArbOS version 50 and above
  • Transfer legacy model parameters and backlog as a constraint for multi-constraints
  • Override behaviour for precompile methods when multi-constraints pricer enabled
  • System test for constraints management and transition

@github-actions

github-actions Bot commented Oct 16, 2025

Copy link
Copy Markdown
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@MishkaRogachev MishkaRogachev force-pushed the add-precompiles-for-multi-constraint-pricer branch 2 times, most recently from 6ab7990 to 60168e0 Compare October 17, 2025 18:11
@MishkaRogachev MishkaRogachev changed the title Add precompiles for Multi-Constraint Pricer (stubs) Add precompiles for Multi-Constraint Pricer Oct 17, 2025
@MishkaRogachev MishkaRogachev force-pushed the add-precompiles-for-multi-constraint-pricer branch from 60168e0 to 708fcd3 Compare October 17, 2025 18:19
@MishkaRogachev MishkaRogachev marked this pull request as ready for review October 17, 2025 18:19
Comment thread precompiles/precompile_test.go Outdated
@gligneul gligneul assigned MishkaRogachev and unassigned gligneul Oct 17, 2025
Comment thread contracts-local/src/precompiles
gligneul
gligneul previously approved these changes Oct 20, 2025
Comment thread precompiles/ArbGasInfo.go
@eljobe eljobe assigned MishkaRogachev and unassigned eljobe Oct 20, 2025
@MishkaRogachev MishkaRogachev force-pushed the add-precompiles-for-multi-constraint-pricer branch from 2fb45db to d1d0e7d Compare October 23, 2025 20:55
Comment thread precompiles/ArbOwner.go Outdated
// Each new precompile contract and each method on new or existing precompile
// contracts should be counted.
expectedNewEntriesPerArbosVersion := map[uint64]int{
0: 102,

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised to see this drop from 102 to 99.
Where did the 3 precompiles that were available since version 0 go?
I wouldn't expect this to change over time.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was another PR that included the changes in nitro-precompiles-interfaces, and committed to master the new precompiles as if they were from version 0. This is just fixing that (and we should fix this before releasing a version).

@MishkaRogachev MishkaRogachev force-pushed the add-precompiles-for-multi-constraint-pricer branch from d1d0e7d to 117c152 Compare October 24, 2025 11:08
@MishkaRogachev MishkaRogachev force-pushed the add-precompiles-for-multi-constraint-pricer branch from 117c152 to f643023 Compare October 24, 2025 11:09
@eljobe eljobe added this pull request to the merge queue Oct 24, 2025
Merged via the queue into master with commit 15e82c9 Oct 24, 2025
25 checks passed
@eljobe eljobe deleted the add-precompiles-for-multi-constraint-pricer branch October 24, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants