fix(ui): honor OBOL_NONINTERACTIVE on a real TTY - #789
Merged
Conversation
OisinKyne
approved these changes
Jul 20, 2026
Reported by a teammate during v0.14.0-rc0 field testing. https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v
OisinKyne
force-pushed
the
fix/noninteractive-prompt-guard
branch
from
July 20, 2026 14:57
a04c05d to
24a511d
Compare
OisinKyne
enabled auto-merge (rebase)
July 20, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
OBOL_NONINTERACTIVE=truehad no effect on a real TTY.internal/ui/prompt.go'sisInteractive()gated prompting on JSON-output mode and TTY detection only:It never consulted the env var, so scripted/automated runs launched from a real
terminal (e.g. CI runners with a pty, installer wrappers) still hit every
Confirm/Select/Inputcall and blocked waiting on stdin — including the"start cluster now?" and Ollama-model prompts during
obol stack up.Audited every
Confirm/Selectcall site in the codebase (internal/app,internal/openclaw,internal/network,internal/tunnel,internal/stackbackup,internal/hermes,internal/stack/safety.go,cmd/obol/*.go): all of themalready route through
UI.Confirm/UI.Select, and there is no rawsurvey/promptui prompt anywhere in
internal/. The Ollama-detection logic ininternal/stack/stack.goonly warns/logs when no models are pulled — itnever calls
Confirm. So the singleisInteractive()guard is the one andonly chokepoint; no other call site needed touching.
Fix
isInteractive()now also requiresOBOL_NONINTERACTIVEis not"true":Every prompt (
Confirm,Select,Input,InputWithSuffix,SecretInput)already short-circuits through
isInteractive()and falls back to itsdefault/error path, so this one guard covers all of them.
Diagram
flowchart LR A[OBOL_NONINTERACTIVE env var] --> D{isInteractive guard} B[IsJSON] --> D C[IsTTY] --> D D -- "any condition false" --> E["Confirm/Select/Input\nreturn default (no prompt)"] D -- "all true" --> F["Confirm/Select/Input\nprompt on stdin"]Validation
https://claude.ai/code/session_01PnhCQLz7CHuDBUhWd5xF8v