fix(serviceoffer): require 2xx for UpstreamHealthy probes - #758
Merged
Conversation
Previously any status <500 counted as healthy, so a 404 healthPath left offers Ready while paid traffic failed. Match real liveness: 2xx only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UpstreamHealthytreated any HTTP status <500 as healthy, so a wronghealthPathreturning 404 still setUpstreamHealthy=Trueand allowedReady=Truewhile paid traffic 404'd.Now only 2xx counts as healthy.
Test plan
go test ./internal/serviceoffercontroller/ -run TestUpstreamHealthStatusOKPart of v0.14.0-rc0 hackathon bugfix train.