fix(defaults): rewrite :latest image pins to the dev tag (job-broker ImagePullBackOff) - #719
Merged
Merged
Conversation
…EVELOPMENT The dev-mode manifest rewrite (rewriteDevDigestPins) only matched digest and short-SHA pins. job-broker ships as :latest (it has no published ghcr image, so the release pipeline has no digest to stamp), so its deployment ref survived the rewrite unchanged. The local build imports it as :dev-<sha>, leaving no :latest image present, so the pod ImagePullBackOffs against the unpublished registry ref and blocks flow-02. Add :latest to the rewrite alternation — a locally-built base always resolves to the dev build, so an unpinned ref must point at it too. Surfaced by the v0.13.0-rc1 release smoke on spark1. Claude-Session: https://claude.ai/code/session_01VquWN9UMaSHH7MHGcG8bw1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Under
OBOL_DEVELOPMENT=true,rewriteDevDigestPinsrepoints component image refs at the freshly-built local:dev-<sha>tag. It matched digest and short-SHA pins but not:latest.job-brokerships as:latest(no published ghcr image → no digest for the release pipeline to stamp), so its Deployment ref survived the rewrite → the local build imports:dev-<sha>, no:latestimage exists → pod ImagePullBackOff, blockingflow-02.Fix: add
:latestto the rewrite alternation (a locally-built base always resolves to the dev build, so an unpinned ref must point at it too). Regression test assertsjob-brokeris rewritten and no:latestsurvives for any locally-built base.How found
Surfaced by the v0.13.0-rc1 release smoke on a real k3d cluster (spark1) — job-broker was the only pod stuck in ImagePullBackOff while the digest-pinned verifier/controller/buyer came up fine.
Follow-up (flagged, not in this PR)
job-brokeris absent from.github/workflows/docker-publish-x402.yml, so:latestnever resolves in a production install either. This dev fix unblocks rc smoke; adding job-broker to the publish matrix is required before a GA tag.https://claude.ai/code/session_01VquWN9UMaSHH7MHGcG8bw1