Fix AutoExpand Issues with Capitalized $Expand System Query Options - #1292
Merged
WanjohiSammy merged 16 commits intoSep 6, 2024
Conversation
…OData query parameters to prevent duplicates
…r better readability and maintability
WanjohiSammy
requested review from
ElizabethOkerio,
KenitoInc,
gathogojr,
habbes and
xuzhg
August 5, 2024 11:12
habbes
reviewed
Aug 14, 2024
habbes
reviewed
Aug 14, 2024
habbes
reviewed
Aug 14, 2024
habbes
reviewed
Aug 14, 2024
habbes
reviewed
Aug 14, 2024
Contributor
|
@WanjohiSammy does this issue only affect AutoExpand? Also do we have tests for query options without a $ prefix? |
…lIgnoreCase comparer instead of ToLowerInvariant()
Member
Author
@habbes This addresses the issue of Select or Expand AutoExpand navigation property using capitalized |
habbes
reviewed
Aug 16, 2024
habbes
reviewed
Aug 16, 2024
xuzhg
reviewed
Aug 19, 2024
xuzhg
reviewed
Aug 19, 2024
xuzhg
reviewed
Aug 19, 2024
gathogojr
reviewed
Sep 2, 2024
gathogojr
reviewed
Sep 2, 2024
gathogojr
reviewed
Sep 2, 2024
gathogojr
reviewed
Sep 2, 2024
gathogojr
reviewed
Sep 2, 2024
gathogojr
reviewed
Sep 2, 2024
gathogojr
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #1284.
Description
When using AutoExpand, and specifying a system query option that's not lower case (such as $Expand) an exception is thrown. The exception indicates that Expand is being added twice.
This change is to resolve issues with the AutoExpand when using capitalized
$Expandsystem query optionsFor example, given the following entities where
Friendsprop andTripclass are AutoExpandWith this change, we should be able to use
$Expand(capitalized of $expand) with the AutoExpand navigation properties:Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.