[FIX] web_decimal_numpad_dot: Restore keyboard navigation#1158
Merged
pedrobaeza merged 1 commit intoJan 18, 2019
Merged
Conversation
When OCA#1154 switched to using `keydown` as the event to trigger the numpad dot replacement, it was actually [disabling upstream's `_onKeyDown()`][1], which in turn disabled the keyboard navigation. To fix this situation, I replaced the method that is being used to directly override `_onKeyDown`. [1]: https://github.com/odoo/odoo/blob/19558129f0e2d5c9940f6fa95534840f8f025547/addons/web/static/src/js/fields/abstract_field.js#L41
pedrobaeza
approved these changes
Jan 18, 2019
carlosdauden
approved these changes
Jan 18, 2019
chienandalu
approved these changes
Jan 18, 2019
pedrobaeza
deleted the
11.0-web_decimal_numpad_dot-fix_keyboard_navigation
branch
Member
Author
|
Cherry-picked in v12 at 67f76e8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #1154 switched to using
keydownas the event to trigger the numpad dot replacement, it was actually disabling upstream's_onKeyDown(), which in turn disabled the keyboard navigation.To fix this situation, I replaced the method that is being used to directly override
_onKeyDown.@Tecnativa