Skip to content

[IMP] queue_job: add configuration options for#480

Merged
OCA-git-bot merged 1 commit into
OCA:14.0from
repodevs:queue_job_config
Nov 23, 2022
Merged

[IMP] queue_job: add configuration options for#480
OCA-git-bot merged 1 commit into
OCA:14.0from
repodevs:queue_job_config

Conversation

@repodevs

@repodevs repodevs commented Nov 2, 2022

Copy link
Copy Markdown
Member

jobrunner_db_user, jobrunner_db_password

this PR improving #86 to add options for allowing using custom db_user and db_password.

the reason is same as in OCA/connector#248 , but using custom pool_mode for difference users

@OCA-git-bot

OCA-git-bot commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@repodevs

repodevs commented Nov 16, 2022

Copy link
Copy Markdown
Member Author

Hello @guewen would you take a look on this one?

guewen
guewen approved these changes Nov 17, 2022
View reviewed changes

@guewen guewen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, it makes sense, thanks!

simahawk
simahawk approved these changes Nov 17, 2022
View reviewed changes

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@simahawk

simahawk commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-480-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 17, 2022
@OCA-git-bot
Merge PR #480 into 14.0
fe0f538 
Signed-off-by simahawk
@OCA-git-bot

OCA-git-bot commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 14.0-ocabot-merge-pr-480-by-simahawk-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@simahawk

simahawk commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

Fixing the build here #484

@repodevs

repodevs commented Nov 22, 2022

Copy link
Copy Markdown
Member Author

Hi @simahawk looks like the merge failed, could you re-merge again?

@simahawk

simahawk commented Nov 22, 2022

Copy link
Copy Markdown
Contributor

@repodevs pls rebase this PR

@repodevs
[IMP] queue_job: add configuration options for
5f88783 
jobrunner_db_user, jobrunner_db_password
@repodevs

repodevs commented Nov 23, 2022

Copy link
Copy Markdown
Member Author

@simahawk Done ✅

@simahawk

simahawk commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

/ocabot merge minor

@OCA-git-bot

OCA-git-bot commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-480-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3620349 into OCA:14.0 Nov 23, 2022
@OCA-git-bot

OCA-git-bot commented Nov 23, 2022

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 1c127af. Thanks a lot for contributing to OCA. ❤️

@simahawk simahawk mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes

@guewen guewen guewen approved these changes

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@repodevs @OCA-git-bot @simahawk @guewen