Skip to content

[10.0] retry_postpone using new cursor #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guewen merged 11 commits into from
May 25, 2018
Merged

[10.0] retry_postpone using new cursor #41

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
825d8e9
retry_postpone with rollback and new cursor
2zx Nov 25, 2017
59f3409
no need to rollback
2zx Dec 2, 2017
e5de796
rollback and clear
2zx Dec 10, 2017
1b94e84
timeout long enough to wait for server startup
2zx Dec 11, 2017
bd9fd7a
better autovacuum
Apr 27, 2018
9c62069
typo
2zx Apr 29, 2018
bec2256
typo
2zx Apr 29, 2018
edec8f4
Revert "typo"
2zx May 24, 2018
37ca09e
Revert "typo"
2zx May 24, 2018
e2eb629
Revert "better autovacuum"
2zx May 24, 2018
b504045
Revert "timeout long enough to wait for server startup"
2zx May 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions queue_job/controllers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,16 @@ def runjob(self, db, job_uuid, **kw):
env = http.request.env(user=odoo.SUPERUSER_ID)

def retry_postpone(job, message, seconds=None):
job.postpone(result=message, seconds=seconds)
job.set_pending(reset_retry=False)
job.store()
env.cr.commit()

job.env.cr.rollback()

@simahawk simahawk Jan 8, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't you rollback only in case of errors? /cc @guewen

@guewen guewen Jan 22, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's there to prevent a conflict between the job.env's transaction and the new one. The job record might have been updated by the first one and will be updated by the second one? It's not called in the FailedJobError case though so why is it necessary here?

job.env.clear()
with odoo.api.Environment.manage():
with odoo.registry(job.env.cr.dbname).cursor() as new_cr:
job.env = job.env(cr=new_cr)
job.postpone(result=message, seconds=seconds)
job.set_pending(reset_retry=False)
job.store()
new_cr.commit()

job = self._load_job(env, job_uuid)
if job is None:
Expand Down