Skip to content

Retry "Unable to use closed cursor" #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guewen wants to merge 1 commit into from
Closed

Retry "Unable to use closed cursor" #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions queue_job/controllers/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@ def runjob(self, db, job_uuid, **kw):
env = http.request.env(user=odoo.SUPERUSER_ID)

def retry_postpone(job, message, seconds=None):

job.env.cr.rollback()
if not job.env.cr._closed:
job.env.cr.rollback()
job.env.clear()
with odoo.api.Environment.manage():
with odoo.registry(job.env.cr.dbname).cursor() as new_cr:
Expand All @@ -105,13 +105,27 @@ def retry_postpone(job, message, seconds=None):
except OperationalError as err:
# Automatically retry the typical transaction serialization
# errors
if err.pgcode not in PG_CONCURRENCY_ERRORS_TO_RETRY:
if err.pgcode in PG_CONCURRENCY_ERRORS_TO_RETRY:
retry_postpone(
job,
tools.ustr(err.pgerror, errors='replace'),
seconds=PG_RETRY
)
_logger.debug('%s OperationalError, postponed', job)
elif unicode(err).startswith(
u'Unable to use a closed cursor.'
):
# This error is raised by odoo in sql_db.py, it raises
# an OperationalError but leave pgcode and pgerror empty,
# we can only rely on the name which is hardcoded.
# This error is likely to work in a fresh environment.
retry_postpone(job, unicode(err), seconds=PG_RETRY)
_logger.debug(
'%s unable to use a closed cursor, postponed', job
)
else:
raise

retry_postpone(job, tools.ustr(err.pgerror, errors='replace'),
seconds=PG_RETRY)
_logger.debug('%s OperationalError, postponed', job)

except NothingToDoJob as err:
if unicode(err):
msg = unicode(err)
Expand Down